strongduanmu commented on code in PR #26332:
URL: https://github.com/apache/shardingsphere/pull/26332#discussion_r1261981825
##########
test/it/parser/src/main/resources/case/ddl/create-table.xml:
##########
@@ -51,8 +78,11 @@
<column-definition type="varchar" start-index="39" stop-index="56">
<column name="status" />
</column-definition>
+ <create-table-option start-index="59" stop-index="95">
+ <engine name="InnoDB" start-index="66" stop-index="71" />
+ </create-table-option>
</create-table>
-
Review Comment:
Please keep same indent with previous line.
##########
parser/sql/statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/dialect/statement/mysql/ddl/MySQLCreateTableStatement.java:
##########
@@ -46,4 +49,12 @@ public final class MySQLCreateTableStatement extends
CreateTableStatement implem
public Optional<SimpleTableSegment> getLikeTable() {
return Optional.ofNullable(likeTable);
}
+
+ /**
+ * Get create table option segment.
Review Comment:
Please add new line after java doc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
