pandalee99 commented on code in PR #27251:
URL: https://github.com/apache/shardingsphere/pull/27251#discussion_r1266124347
##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/common/sqlbuilder/PipelineImportSQLBuilder.java:
##########
@@ -44,12 +46,20 @@ public final class PipelineImportSQLBuilder {
private final PipelineSQLSegmentBuilder sqlSegmentBuilder;
- private final ConcurrentMap<String, String> sqlCacheMap;
+ private final Cache<String, String> sqlCache;
- public PipelineImportSQLBuilder(final DatabaseType databaseType) {
+ public PipelineImportSQLBuilder(final DatabaseType databaseType,final
ShardingCacheOptionsConfiguration cacheOptions) {
Review Comment:
This confused me a lot, but I had two thoughts:
1. Specify parameters directly in the constructor without using cacheOptions
2. Use cacheOptions, but many classes also need to modify methods
So I prefer 1.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
