sandynz commented on code in PR #27251:
URL: https://github.com/apache/shardingsphere/pull/27251#discussion_r1266690432
##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/core/importer/sink/PipelineDataSourceSink.java:
##########
@@ -259,8 +258,7 @@ private void executeUpdate(final Connection connection,
final DataRecord dataRec
private void executeBatchDelete(final Connection connection, final
List<DataRecord> dataRecords) throws SQLException {
DataRecord dataRecord = dataRecords.get(0);
- String deleteSQL =
importSQLBuilder.buildDeleteSQL(getSchemaName(dataRecord.getTableName()),
dataRecord,
- RecordUtils.extractConditionColumns(dataRecord,
importerConfig.getShardingColumns(dataRecord.getTableName())));
+ String deleteSQL =
importSQLBuilder.buildDeleteSQL(getSchemaName(dataRecord.getTableName()),
dataRecord, RecordUtils.extractConditionColumns(dataRecord,
importerConfig.getShardingColumns(dataRecord.getTableName())));
Review Comment:
1, Existing code could be kept without modification.
2, There's error in CheckStyle: `Line is longer than 200 characters (found
224). (261:0) [LineLength]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
