yu199195 commented on a change in pull request #4825: orchestration mode code
optimization .
URL:
https://github.com/apache/incubator-shardingsphere/pull/4825#discussion_r394231745
##########
File path:
sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-configcenter/src/main/java/org/apache/shardingsphere/orchestration/core/configcenter/ConfigCenter.java
##########
@@ -180,13 +180,12 @@ private void persistShardingSchemaName(final String
shardingSchemaName) {
repository.persist(node.getSchemaPath(), shardingSchemaName);
return;
}
- List<String> schemaNameList =
Splitter.on(",").splitToList(shardingSchemaNames);
+ List<String> schemaNameList =
Lists.newArrayList(Splitter.on(",").split(shardingSchemaNames));
Review comment:
splitToList return readOnly List,and Then the list will add,
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
