kimmking commented on a change in pull request #4825: orchestration mode code
optimization .
URL:
https://github.com/apache/incubator-shardingsphere/pull/4825#discussion_r394315244
##########
File path:
sharding-orchestration/sharding-orchestration-center/sharding-orchestration-center-zookeeper-curator/src/main/java/org/apache/shardingsphere/orchestration/center/instance/CuratorZookeeperCenterRepository.java
##########
@@ -228,7 +228,7 @@ public void watch(final String key, final
DataChangedEventListener dataChangedEv
}
DataChangedEvent.ChangedType changedType = getChangedType(event);
if (DataChangedEvent.ChangedType.IGNORED != changedType) {
- dataChangedEventListener.onChange(new
DataChangedEvent(data.getPath(), null == data.getData() ? null : new
String(data.getData(), "UTF-8"), changedType));
+ dataChangedEventListener.onChange(new
DataChangedEvent(data.getPath(), null == data.getData() ? null : new
String(data.getData(), Charsets.UTF_8), changedType));
Review comment:
don't refer guava
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
