strongduanmu commented on code in PR #30729:
URL: https://github.com/apache/shardingsphere/pull/30729#discussion_r1546152308
##########
parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/PLSQL.g4:
##########
@@ -574,15 +588,15 @@ plsqlTriggerSource
;
simpleDmlTrigger
- : (BEFORE | AFTER) dmlEventClause (FOR EACH ROW)? triggerBody
+ : (BEFORE | AFTER) dmlEventClause (FOR EACH ROW)? () ? triggerBody
Review Comment:
Is this writing legal in Oracle?
##########
parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/PLSQL.g4:
##########
@@ -216,6 +217,12 @@ iterationCtlSeq
: qualIterationCtl (COMMA_ qualIterationCtl)*
;
+modifyingExpression
+ : INSERTING
+ | DELETING
Review Comment:
Can you combine these subrules into one line? Line breaks are required only
when the subrule exceeds 5.
##########
parser/sql/dialect/oracle/src/main/antlr4/imports/oracle/PLSQL.g4:
##########
@@ -314,6 +321,13 @@ ifStatement
END IF SEMI_
;
+modifyingStatement
+ : IF modifyingExpression THEN statement+
Review Comment:
Can you combine these subrules into one line? Line breaks are required only
when the subrule exceeds 5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
