terrymanu commented on a change in pull request #4850: #4460, fix order by
string column exception
URL:
https://github.com/apache/incubator-shardingsphere/pull/4850#discussion_r395422844
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/metadata/column/ColumnMetaData.java
##########
@@ -36,4 +37,7 @@
private final String dataType;
private final boolean primaryKey;
+
+ @Setter
+ private boolean isCaseSensitive;
Review comment:
Please do not use setter, we may keep consist with other fields.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
