codecov-io commented on issue #4850: #4460, fix order by string column exception URL: https://github.com/apache/incubator-shardingsphere/pull/4850#issuecomment-601545150 # [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=h1) Report > Merging [#4850](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/6f9294f0afea087673dbbc6d96b7894e086ba26f?src=pr&el=desc) will **decrease** coverage by `0.21%`. > The diff coverage is `44.23%`. [](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #4850 +/- ## ============================================ - Coverage 56.19% 55.98% -0.22% - Complexity 448 449 +1 ============================================ Files 1163 1166 +3 Lines 20895 20902 +7 Branches 3880 3892 +12 ============================================ - Hits 11742 11701 -41 - Misses 8424 8471 +47 - Partials 729 730 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...r/binder/metadata/column/ColumnMetaDataLoader.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWJpbmRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9iaW5kZXIvbWV0YWRhdGEvY29sdW1uL0NvbHVtbk1ldGFEYXRhTG9hZGVyLmphdmE=) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../execute/sql/execute/result/MemoryQueryResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWV4ZWN1dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2V4ZWN1dGUvc3FsL2V4ZWN1dGUvcmVzdWx0L01lbW9yeVF1ZXJ5UmVzdWx0LmphdmE=) | `96.15% <0%> (-1.89%)` | `0 <0> (ø)` | | | [.../execute/sql/execute/result/StreamQueryResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLWV4ZWN1dGUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5nL2V4ZWN1dGUvc3FsL2V4ZWN1dGUvcmVzdWx0L1N0cmVhbVF1ZXJ5UmVzdWx0LmphdmE=) | `92.45% <0%> (-1.78%)` | `0 <0> (ø)` | | | [...g/merge/dql/orderby/OrderByStreamMergedResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9kcWwvb3JkZXJieS9PcmRlckJ5U3RyZWFtTWVyZ2VkUmVzdWx0LmphdmE=) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...g/merge/dql/groupby/GroupByStreamMergedResult.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9kcWwvZ3JvdXBieS9Hcm91cEJ5U3RyZWFtTWVyZ2VkUmVzdWx0LmphdmE=) | `94.11% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...phere/sharding/merge/dql/orderby/OrderByValue.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9kcWwvb3JkZXJieS9PcmRlckJ5VmFsdWUuamF2YQ==) | `80% <65.21%> (-13.55%)` | `0 <0> (ø)` | | | [...re/sharding/merge/dql/ShardingDQLResultMerger.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmctY29yZS9zaGFyZGluZy1jb3JlLW1lcmdlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9zaGFyZGluZy9tZXJnZS9kcWwvU2hhcmRpbmdEUUxSZXN1bHRNZXJnZXIuamF2YQ==) | `69.23% <75%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [...lying/common/config/TypeBasedSPIConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtdW5kZXJseWluZy9zaGFyZGluZ3NwaGVyZS1jb21tb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3VuZGVybHlpbmcvY29tbW9uL2NvbmZpZy9UeXBlQmFzZWRTUElDb25maWd1cmF0aW9uLmphdmE=) | `0% <0%> (-85.72%)` | `0% <0%> (ø)` | | | [.../command/query/text/query/MySQLComQueryPacket.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9jb21tYW5kL3F1ZXJ5L3RleHQvcXVlcnkvTXlTUUxDb21RdWVyeVBhY2tldC5qYXZh) | `62.5% <0%> (-37.5%)` | `0% <0%> (ø)` | | | [...nlog/row/column/value/time/MySQLTimeValueUtil.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wvc2hhcmRpbmdzcGhlcmUtZGF0YWJhc2UtcHJvdG9jb2wtbXlzcWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RhdGFiYXNlL3Byb3RvY29sL215c3FsL3BhY2tldC9iaW5sb2cvcm93L2NvbHVtbi92YWx1ZS90aW1lL015U1FMVGltZVZhbHVlVXRpbC5qYXZh) | `66.66% <0%> (-16.67%)` | `0% <0%> (ø)` | | | ... and [73 more](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=footer). Last update [6f9294f...79a8c00](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4850?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
