strongduanmu commented on code in PR #33380:
URL: https://github.com/apache/shardingsphere/pull/33380#discussion_r1817995465
##########
features/sharding/core/src/main/java/org/apache/shardingsphere/sharding/merge/dql/groupby/GroupByMemoryMergedResult.java:
##########
@@ -143,22 +138,10 @@ private boolean getValueCaseSensitiveFromTables(final
QueryResult queryResult,
private List<MemoryQueryResultRow> getMemoryResultSetRows(final
SelectStatementContext selectStatementContext,
final
Map<GroupByValue, MemoryQueryResultRow> dataMap, final List<Boolean>
valueCaseSensitive) {
if (dataMap.isEmpty()) {
- Object[] data = generateReturnData(selectStatementContext);
- return Arrays.stream(data).anyMatch(Objects::nonNull) ?
Collections.singletonList(new MemoryQueryResultRow(data)) :
Collections.emptyList();
+ return Collections.emptyList();
}
List<MemoryQueryResultRow> result = new ArrayList<>(dataMap.values());
result.sort(new GroupByRowComparator(selectStatementContext,
valueCaseSensitive));
return result;
}
-
- private Object[] generateReturnData(final SelectStatementContext
selectStatementContext) {
Review Comment:
Hi @Malaydewangan09, can you add a e2e test case for this issue -
https://github.com/apache/shardingsphere/issues/4680
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
