strongduanmu commented on PR #33380:
URL: https://github.com/apache/shardingsphere/pull/33380#issuecomment-2443221245
> @strongduanmu I have merged the master branch So the code which I
corrected earlier was incorrect?
>
> ```
> private List<MemoryQueryResultRow> getMemoryResultSetRows(final
SelectStatementContext selectStatementContext,
> final
Map<GroupByValue, MemoryQueryResultRow> dataMap, final List<Boolean>
valueCaseSensitive) {
> if (dataMap.isEmpty()) {
> return Collections.emptyList();
> }
> List<MemoryQueryResultRow> result = new
ArrayList<>(dataMap.values());
> result.sort(new GroupByRowComparator(selectStatementContext,
valueCaseSensitive));
> return result;
> }
> ```
>
> Since the all test cases that you have updated are similar to what i wrote.
Yes, you can't remove this logic, it's meaningful for #4680. You can keep
the first case and delete the others.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
