tristaZero commented on a change in pull request #5206: Simplify the
SelectStatement
URL:
https://github.com/apache/incubator-shardingsphere/pull/5206#discussion_r410070271
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/statement/dml/SelectStatementContext.java
##########
@@ -93,10 +99,10 @@ public SelectStatementContext(final SelectStatement
sqlStatement, final GroupByC
public SelectStatementContext(final SchemaMetaData schemaMetaData, final
String sql, final List<Object> parameters, final SelectStatement sqlStatement) {
super(sqlStatement);
- tablesContext = new
TablesContext(sqlStatement.getSimpleTableSegments());
+ tablesContext = new
TablesContext(getSimpleTableSegments(sqlStatement));
groupByContext = new
GroupByContextEngine().createGroupByContext(sqlStatement);
orderByContext = new
OrderByContextEngine().createOrderBy(sqlStatement, groupByContext);
- projectionsContext = new
ProjectionsContextEngine(schemaMetaData).createProjectionsContext(sql,
sqlStatement, groupByContext, orderByContext);
+ projectionsContext = new
ProjectionsContextEngine(schemaMetaData).createProjectionsContext(sql, this,
groupByContext, orderByContext);
Review comment:
3. createProjectionsContext(sql, this, groupByContext, orderByContext);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
