tristaZero commented on a change in pull request #5206: Simplify the
SelectStatement
URL:
https://github.com/apache/incubator-shardingsphere/pull/5206#discussion_r410153784
##########
File path:
shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/segment/select/projection/engine/ProjectionsContextEngine.java
##########
@@ -58,17 +57,20 @@ public ProjectionsContextEngine(final SchemaMetaData
schemaMetaData) {
* Create projections context.
*
* @param sql SQL
- * @param selectStatement SQL statement
+ * @param tables tables
+ * @param projectionsSegment projection Segments
* @param groupByContext group by context
* @param orderByContext order by context
* @return projections context
*/
- public ProjectionsContext createProjectionsContext(final String sql, final
SelectStatement selectStatement, final GroupByContext groupByContext, final
OrderByContext orderByContext) {
- ProjectionsSegment projectionsSegment =
selectStatement.getProjections();
- Collection<Projection> projections = getProjections(sql,
selectStatement.getSimpleTableSegments(), projectionsSegment);
+ public ProjectionsContext createProjectionsContext(final String sql, final
Collection<SimpleTableSegment> tables, final ProjectionsSegment
projectionsSegment,
+ final GroupByContext
groupByContext, final OrderByContext orderByContext) {
+// SelectStatement selectStatement = context.getSqlStatement();
Review comment:
Please remove them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
