terrymanu commented on PR #37791: URL: https://github.com/apache/shardingsphere/pull/37791#issuecomment-3806084650
> thanks your review. The changes are becoming more and more extensive and complex. I'm curious how you all are testing these changes. I integrated version 5.5.3-SNAPSHOT into my test project, but it failed to connect to Oracle properly. Only version 5.5.1 works correctly. Before submitting a PR, you need to perform tests, which include connecting to Oracle databases. If you are unable to establish a proper connection to the Oracle database, please explain the reasons. > If I have to submit a PR online every time I make a change and wait for your review, wouldn't that be very cumbersome? I sorry for any inconvenience this may cause, but this is the standard collaboration model in the open-source community. We need to ensure that newly submitted code does not introduce any issues. For a large-scale project like ShardingSphere, extra caution is particularly necessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
