menghaoranss opened a new pull request, #38676:
URL: https://github.com/apache/shardingsphere/pull/38676
Changes proposed in this pull request:
## Description
This PR adds explicit handling for MySQL `lower_case_table_names=0` in
identifier case-rule resolution.
### Changes
- Update `MySQLIdentifierCaseRuleProvider`:
- `SCHEMA/TABLE/VIEW` are case-sensitive when `lower_case_table_names=0`.
- Other scopes (for example `COLUMN/INDEX`) remain case-insensitive.
- Keep existing behavior for `lower_case_table_names=1/2`.
- Add null-connection guard in provider (`getConnection()` may return
`null`).
- Update `DatabaseIdentifierContextFactory` to resolve protocol rules with
datasource context when `ResourceMetaData` is available.
- Fix related tests:
- `MySQLIdentifierCaseRuleProviderTest`
- `DatabaseIdentifierContextFactoryTest`
- `SelectInformationSchemataExecutorTest` (stubbing order / matcher
override issue)
- `MySQLAdminExecutorCreatorTest` (remove unnecessary default datasource
stubbing paths)
- Fix Checkstyle indentation in `try-with-resources`.
### Why
Previously, `lower_case_table_names=0` was not modeled precisely and could
fall back to insensitive behavior.
This PR makes MySQL `0` behavior explicit for schema/table/view lookup while
keeping logical database handling unchanged.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [ ] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
- [ ] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
