menghaoranss commented on PR #38676: URL: https://github.com/apache/shardingsphere/pull/38676#issuecomment-4403327253
Review conclusion: No new issues found, mergeable. I reviewed commit 45e2e7812de; it only updates MySQLIdentifierCaseRuleProvider.java. The change puts Connection into try-with-resources. Behavior stays the same; it only fixes resource cleanup. The connection == null branch is still preserved, and SQLException handling is unchanged. Verification: Targeted test passed: MySQLIdentifierCaseRuleProviderTest (0 failures, 0 errors). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
