terrymanu commented on PR #38755:
URL: https://github.com/apache/shardingsphere/pull/38755#issuecomment-4575686935
### Decision
- **Merge Verdict: Mergeable**
- **Reviewed Scope:** Latest PR head
`9139830134d5aead9878f6bc1029ca0e42730823`; local merge-base
`9d52622e70cc0814e62573cf699e943593919c44`; reviewed the 10 changed files under
`docs/document/content/user-manual/shardingsphere-mcp/`. The local triple-dot
file list matched GitHub `/pulls/38755/files` 10/10.
- **Not Reviewed Scope:** Runtime behavior, CI/check-runs, full Hugo site
rendering, and files outside the GitHub changed-file list.
- **Need Expert Review:** No mandatory security, concurrency, performance,
parser, or protocol expert review needed for this docs-only change.
### Basis
- The PR directly addresses the stated documentation goal: it clarifies that
MCP protocol methods are not `shardingsphere://` resources, keeps
`shardingsphere://capabilities` as the ShardingSphere domain catalog, and
separates core resources from feature plugin resources in
`docs/document/content/user-manual/shardingsphere-mcp/capabilities.en.md:11`.
- The moved plugin-resource boundary is consistent with the feature pages,
which already document encrypt and mask resources at
`docs/document/content/user-manual/shardingsphere-mcp/features/encrypt.en.md:28`
and
`docs/document/content/user-manual/shardingsphere-mcp/features/mask.en.md:27`.
- Protocol-facing statements were checked against ShardingSphere’s own
descriptor/reference surface and the MCP 2025-11-25 spec:
- ShardingSphere reference lists the same protocol surface in
`docs/document/content/reference/mcp/protocol-surface.en.md:11`.
- Core descriptors expose the documented core resources and templates from
`mcp/core/src/main/resources/META-INF/shardingsphere-mcp/mcp-descriptors/mcp-descriptor-core.yaml:18`.
- Feature descriptors expose plugin resources from
`mcp/features/encrypt/src/main/resources/META-INF/shardingsphere-mcp/mcp-descriptors/mcp-descriptor-encrypt.yaml:18`
and
`mcp/features/mask/src/main/resources/META-INF/shardingsphere-mcp/mcp-descriptors/mcp-descriptor-mask.yaml:18`.
- MCP transport/session wording aligns with the official [Streamable HTTP
transport](https://modelcontextprotocol.io/specification/2025-11-25/basic/transports)
and
[lifecycle](https://modelcontextprotocol.io/specification/2025-11-25/basic/lifecycle)
pages.
- Fresh adversarial pass:
- Cross-dialect/parser regression: not applicable; no parser, SQL grammar,
binder, routing, or dialect code is changed.
- Adjacent-feature regression: encrypt and mask plugin resource pages
remain present and aligned with descriptors.
- Config-disabled / physical-database path: the docs still distinguish
Proxy rule capabilities from direct physical JDBC metadata paths in
`docs/document/content/user-manual/shardingsphere-mcp/configuration.en.md:73`
and
`docs/document/content/user-manual/shardingsphere-mcp/configuration.en.md:89`.
- Original symptom coverage: the updated capability page now explicitly
separates protocol methods, resource URIs, tools, prompts, and completions.
### Verification
- Reviewer-run checks:
- `git fetch apache master:refs/remotes/apache/master
pull/38755/head:refs/remotes/apache/pr/38755` exited `0`.
- `git diff --name-status $(git merge-base refs/remotes/apache/master
refs/remotes/apache/pr/38755)..refs/remotes/apache/pr/38755` exited `0`.
- GitHub file-list comparison against the local triple-dot diff exited `0`.
- `git diff --check $(git merge-base refs/remotes/apache/master
refs/remotes/apache/pr/38755)..refs/remotes/apache/pr/38755 --
docs/document/content/user-manual/shardingsphere-mcp` exited `0`.
- `git status --short --branch` exited `0`; no local file edits were made.
- No Maven, Spotless, Checkstyle, or docs-site build was run because this
was a review-only docs PR and I did not modify files.
- GitHub Actions / CI status was intentionally not used for the verdict.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
