terrymanu commented on PR #38757: URL: https://github.com/apache/shardingsphere/pull/38757#issuecomment-4576941957
### Decision - **Merge Verdict: Mergeable** - **Reviewed Scope:** Latest PR head `32d9635d48357ba2481aa3f643a90b0080b4ad5a`, base `346972203f8a95f66a01f23ee4366e2dd0ab145c`, merge-base `d6fdf6e11d7f080614e0bf29ab27dacf8b9750dd`. GitHub `/pulls/38757/files` matches the local triple-dot diff: 19 files. - **Target Topology:** ShardingSphere-MCP HTTP/STDIO clients connected to ShardingSphere-Proxy logical databases. Direct physical database paths remain documented as not applicable for encrypt/mask rule workflows. - **Not Reviewed:** GitHub Actions / CI status and full `clean install`. ### Basis The previous blocker is fixed. The encrypt and mask EN/CN docs now document `operation_type=drop`, include drop examples, explain sibling-rule behavior, and retain safety limits such as no automatic rollback and no restoration of historical plaintext for encryption. The documented behavior is consistent with the runtime surface: encrypt/mask descriptors still expose `create`, `alter`, and `drop`; the planning services generate `ALTER ... RULE` when sibling columns remain and `DROP ... RULE` only when the target table has no remaining rule columns. Risk scan found no parser, routing, name-resolution, SQL dialect, SPI, dependency, or high-frequency execution-path changes. The shared MCP model-contract change is wording-only and is covered by unit assertions plus the E2E capability baseline update. ### Verification - `git fetch apache master:refs/remotes/apache/master pull/38757/head:refs/remotes/apache/pr/38757` exit 0. - GitHub file-list vs local triple-dot diff check exit 0. - Old `create/alter only` wording search exit 1 as expected; `operation_type=drop`, `DROP ENCRYPT RULE`, `DROP MASK RULE`, and rollback/safety notes are present. - `git diff --check refs/remotes/apache/master...refs/remotes/apache/pr/38757` exit 0. - `./mvnw -pl mcp/support,mcp/core -am -DskipITs -Dspotless.skip=true -Dtest=MCPModelFirstContractPayloadBuilderTest,ServerCapabilitiesHandlerTest -Dsurefire.failIfNoSpecifiedTests=false test` exit 0. - `./mvnw -pl mcp/features/encrypt,mcp/features/mask -am -DskipITs -Dspotless.skip=true -Dtest=EncryptRuleDistSQLPlanningServiceTest,EncryptWorkflowPlanningServiceTest,MaskRuleDistSQLPlanningServiceTest,MaskWorkflowPlanningServiceTest,MaskWorkflowIntentResolverTest -Dsurefire.failIfNoSpecifiedTests=false test` exit 0. - Same latest-head content was previously formatted and style-checked with `./mvnw spotless:apply -Pcheck -T1C` exit 0 and `./mvnw checkstyle:check -Pcheck -T1C` exit 0. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
