RaigorJiang opened a new pull request, #38766: URL: https://github.com/apache/shardingsphere/pull/38766
Fix nightly-ci: https://github.com/apache/shardingsphere/actions/workflows/nightly-ci.yml Error: <img width="1530" height="788" alt="PixPin_2026-06-01_11-52-02" src="https://github.com/user-attachments/assets/fe81283e-7dac-40f7-ac3d-6c42e52874ab"; /> The GitHub Action failure was caused by stale Windows-specific expected lengths in two URL loader tests, not by an actual loader behavior regression. Both ClassPathLocalFileURLLoader and AbsolutePathLocalFileURLLoader read the YAML fixture line by line and then rebuild the content using System.lineSeparator(). This means the returned string length is OS-dependent: - On Linux/macOS, System.lineSeparator() is \n, so each joined line separator contributes 1 character. - On Windows, System.lineSeparator() is \r\n, so each joined line separator contributes 2 characters. The fixture was changed in commit 526ac5aaf30 (Remove keyGenerateStrategy for ShardingTableRuleConfiguration (#38609)). That commit updated the Linux/macOS expected length from 1783 to 1872, but the Windows expected length was left at the old value 1839. With the current fixture: `61 lines, 1873 bytes` Because the file has Linux line endings and ends with a newline: ``` Non-line-separator characters = 1873 - 61 = 1812 Joined separators between 61 lines = 60 ``` So the expected lengths are: ``` Linux/macOS: 1812 + 60 * 1 = 1872 Windows: 1812 + 60 * 2 = 1932 ``` The CI failure reported: ```plain Expected: is <1839> but: was <1932> ``` That matches the correct current Windows length. Therefore, the root cause is that the Windows assertion values in ClassPathLocalFileURLLoaderTest and AbsolutePathLocalFileURLLoaderTest were not updated after the fixture content changed. The fix is to update the Windows expected length from 1839 to 1932 in both tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
