dahyvuun opened a new pull request, #2513:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2513

   When a sharding item fails during job execution, the running node in the 
registry center should not be removed so that failover can be triggered 
correctly. Previously, registerJobCompleted always removed all running nodes 
regardless of execution result, causing failed items to appear as successfully 
completed to the cluster.
   
   
   
   Fixes #2493 .
   
   Changes proposed in this pull request:
   
   - Add `registerJobCompleted(ShardingContexts, Collection<Integer>)` overload 
to `JobFacade`, `AbstractJobFacade`, and `ExecutionService`
   - Failed items retain their ZK running node; only succeeded items have their 
running node removed and failover-complete node cleared
   - `ElasticJobExecutor` passes `itemErrorMessages.keySet()` as `failedItems`
   - Resolves the TODO comment in `ElasticJobExecutor` regarding job failure 
status


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to