dahyvuun commented on code in PR #2513:
URL:
https://github.com/apache/shardingsphere-elasticjob/pull/2513#discussion_r3413866856
##########
kernel/src/main/java/org/apache/shardingsphere/elasticjob/kernel/executor/facade/JobFacade.java:
##########
@@ -65,6 +65,15 @@ public interface JobFacade {
*/
void registerJobCompleted(ShardingContexts shardingContexts);
+ /**
+ * Register job completed.
+ * Failed items retain their running node so that failover can be
triggered for them.
+ *
+ * @param shardingContexts sharding contexts
+ * @param failedItems sharding items that failed during execution
+ */
+ void registerJobCompleted(ShardingContexts shardingContexts,
Collection<Integer> failedItems);
Review Comment:
Won't fix: AbstractJobFacade already handles delegation, and
SingleShardingJobFacade now overrides the 2-arg method directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
