linghengqian commented on code in PR #2513: URL: https://github.com/apache/shardingsphere-elasticjob/pull/2513#discussion_r3414740761
########## .gitignore: ########## @@ -1,58 +1,58 @@ -# maven ignore -target/ -*.class -*.jar -*.war -*.zip -*.tar -*.tar.gz -dependency-reduced-pom.xml -.flattened-pom.xml -pom.xml.versionsBackup - -# maven plugin ignore -release.properties -*.gpg - -# eclipse ignore -.settings/ -.project -.classpath -.factorypath - -# idea ignore -.idea/ -!/.idea/icon.png -!/.idea/vcs.xml -*.ipr -*.iml -*.iws - -# vscode ignore -.vscode/ - -# temp ignore -logs/ -*.log -*.tlog -*.doc -*.cache -*.diff -*.patch -*.tmp - -# system ignore -.DS_Store -Thumbs.db - -# antlr ignore -gen/ -*.tokens - -# profiler ignore -.profiler/ - -# hugo ignore -public/ -.hugo_build.lock -*.html-e Review Comment: After some thought, I believe changes to the `.gitattributes` file should be made in a separate issue and pull request, mainly because I don't actually have a Windows native development environment to verify them. The `.gitattributes` file can be removed in the current pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
