terrymanu commented on PR #38893:
URL: https://github.com/apache/shardingsphere/pull/38893#issuecomment-4775364711
Review Result: Mergeable
Scope Reviewed:
- PR: apache/shardingsphere#38893
- Head SHA: 39cc1978430ee893d6c16ec17859d31288a04ab2
- Merge base: c9d5d7c550af570545b12af09f8f14aa3c282978
- GitHub file list and local triple-dot diff match: 11 files.
Review Notes:
- `DialectIndexOption` now owns `indexNameMaxLength`, so
`IndexMetaDataUtils` no longer carries PostgreSQL/openGauss/Oracle constants.
- `DialectDatabaseMetaData` keeps the existing default behavior as unlimited
with `Integer.MAX_VALUE`.
- PostgreSQL/openGauss/Oracle metadata define the existing 63/63/30 limits
in their dialect implementations.
- `IndexMetaDataUtils` reads the limit through
`DatabaseTypedSPILoader.findService(...)` and falls back to unlimited when no
dialect metadata is available.
- Direct production caller surface remains the sharding index rewrite path,
with no new bypass or duplicate construction path found.
Verification:
- Local scoped tests passed:
`./mvnw -pl
database/connector/core,database/connector/dialect/postgresql,database/connector/dialect/opengauss,database/connector/dialect/oracle,infra/common
-am -DskipITs -Dspotless.skip=true
-Dtest=DialectDatabaseMetaDataTest,PostgreSQLDatabaseMetaDataTest,OpenGaussDatabaseMetaDataTest,OracleDatabaseMetaDataTest,IndexMetaDataUtilsTest
-Dsurefire.failIfNoSpecifiedTests=false test`
Exit code: 0
- GitHub checks at review time: no completed failures; License, CheckStyle,
Spotless completed successfully. Some CI/E2E jobs were still in progress.
Release Note / User Docs:
- No release note or user documentation update required; this is an internal
metadata placement refactor preserving the existing external index-name
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
