iamhucong opened a new pull request, #38898:
URL: https://github.com/apache/shardingsphere/pull/38898

   ### Motivation
   
   `DDLE2EIT` waits for DDL table or view metadata by polling 
`DatabaseMetaData#getTables(...)`.
   
   `getTables(...)` returns a `ResultSet` that should be closed by the caller. 
The current `containsTable(...)` implementation directly calls `next()` on that 
`ResultSet`, so repeated metadata polling can keep database-side resources open 
longer than necessary.
   
   ### Changes
   
   - Close the `ResultSet` returned by `DatabaseMetaData#getTables(...)` in 
`DDLE2EIT#containsTable(...)` with try-with-resources.
   - Keep the existing table-existence semantics unchanged.
   
   ### Verification
   
   - `./mvnw -pl test/e2e/sql -am -DskipITs -Dspotless.skip=true -DskipTests 
test-compile`
   - `./mvnw spotless:apply -Pcheck -T1C`
   - `./mvnw checkstyle:check -Pcheck -T1C`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to