somiljain2006 commented on PR #38990: URL: https://github.com/apache/shardingsphere/pull/38990#issuecomment-4913803994
@terrymanu Thanks for the detailed review. I've addressed both points in this revision. For P1, I narrowed the scope of the PR to the original non-DISTINCT use case in #37644. Expression-wrapped `DISTINCT` aggregations are no longer extracted as expression-derived aggregations, the DISTINCT-specific regression test has been removed, and the remaining tests only cover non-DISTINCT wrapper expressions. For P2, I updated the memory merge path to use the actual `ExpressionProjection` instance to determine the output column, matching the object-based mapping used by the stream merge path instead of matching by expression text. I also added a regression test covering duplicate `IFNULL(SUM(...), 0)` projections with different aliases to verify that both output columns are updated correctly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
