thswlsqls opened a new pull request, #39138:
URL: https://github.com/apache/shardingsphere/pull/39138
Fixes #39135.
Changes proposed in this pull request:
- In `MySQLTimeBinaryProtocolValue.read()` (length 12 case), multiply the
4-byte fractional field by 1000 before `Timestamp#setNanos`, since the MySQL
binary protocol encodes it as microseconds while `setNanos` expects nanoseconds.
- Aligns with the sibling `MySQLDateBinaryProtocolValue.read()`, which
already applies `readInt4() * 1000`, and with this class's own `writeNanos()`
writing `nanos / 1000`.
- Correct the existing `twelve_bytes` test expectation (which locked in
the bug) and add a `twelve_bytes_fractional_second` case asserting 230000
microseconds decode to 230,000,000 nanoseconds.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
