terrymanu commented on PR #39093: URL: https://github.com/apache/shardingsphere/pull/39093#issuecomment-5002820556
Thanks for clarifying. Please proceed with **option 3** and keep this PR limited to internal support for binding, extracting, and rewriting SQL Server `UPDATE` targets. Multi-statement batch and routine-body rewriting should be handled separately in #30227. Please address the remaining items: 1. Remove the Encrypt release-note entry and revise the PR title/description to avoid claiming user-facing support. The rewriter IT can remain as component-level coverage. 2. Restrict table-variable handling in `SimpleTableSegmentBinder` to SQL Server `UPDATE` targets. It currently also affects `SELECT`, `INSERT`, and `DELETE`, while `TableExtractor` only handles `UPDATE`. 3. Detect unquoted `@` table variables before external-context and physical-metadata lookup. Add regression tests for same-named delimited physical tables or CTEs. Bracketed and double-quoted names must remain physical identifiers. 4. Remove the unrelated `.cursor/` change. The quoted-identifier issue is already fixed. With the scope clarified, a `type: discussion` label is not needed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
