thswlsqls opened a new pull request, #39200:
URL: https://github.com/apache/shardingsphere/pull/39200
Fixes #39199.
Changes proposed in this pull request:
- Broadcast table names are case-insensitive (core `BroadcastRule.tables`
is a `CaseInsensitiveSet`), but two DistSQL executors compared them
case-sensitively.
- `CreateBroadcastTableRuleExecutor.getDuplicatedRuleNames()`: copy
current tables into a `CaseInsensitiveSet` instead of `HashSet`, so `CREATE
BROADCAST TABLE RULE T_ORDER` over an existing `t_order` now raises
`DuplicateRuleException` instead of storing both.
- `DropBroadcastTableRuleExecutor.hasAnyOneToBeDropped()`: wrap current
tables in `CaseInsensitiveSet` before `Collections.disjoint`, so `DROP
BROADCAST TABLE RULE T_ORDER` removes `t_order` instead of being a silent no-op.
- Both align with the executors' own existing `CaseInsensitiveSet` usage
(`checkBroadcastTableExist`, alter builder) and the sibling
`DropMaskRuleExecutor.hasAnyOneToBeDropped()`; completes the drop-path fix
started in #30180.
- Added case-insensitive unit tests to both executor test classes.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
