thswlsqls commented on PR #39200: URL: https://github.com/apache/shardingsphere/pull/39200#issuecomment-5148127747
@terrymanu Thanks — good catch on the contract. `hasAnyOneToBeDropped` no longer calls `Collections.disjoint`; it now builds the `CaseInsensitiveSet` and queries it explicitly for each requested table, matching what `checkBroadcastTableExist` already does, so the case-insensitive match is guaranteed rather than incidental. `DropBroadcastTableRuleExecutorTest` and `CreateBroadcastTableRuleExecutorTest` pass (9 tests). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
