This is an automated email from the ASF dual-hosted git repository.
terrymanu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/shardingsphere.git
The following commit(s) were added to refs/heads/master by this push:
new 43829a8d089 Remove obsolete TODOs and redundant Firebird handling
(#39232)
43829a8d089 is described below
commit 43829a8d089cc4405b0177d1fee96f56293f6b94
Author: Liang Zhang <[email protected]>
AuthorDate: Fri Jul 24 14:27:05 2026 +0800
Remove obsolete TODOs and redundant Firebird handling (#39232)
---
pom.xml | 1 -
.../backend/firebird/handler/admin/FirebirdAdminExecutorCreator.java | 5 -----
test/e2e/sql/src/test/resources/cases/dml/e2e-dml-insert.xml | 1 -
3 files changed, 7 deletions(-)
diff --git a/pom.xml b/pom.xml
index 21437a768e3..adff21ceeee 100644
--- a/pom.xml
+++ b/pom.xml
@@ -812,7 +812,6 @@
</annotationProcessorPaths>
</configuration>
</plugin>
- <!-- TODO nianjun should remove after test container is used
in agent e2e -->
<plugin>
<artifactId>maven-resources-plugin</artifactId>
<version>${maven-resources-plugin.version}</version>
diff --git
a/proxy/backend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/backend/firebird/handler/admin/FirebirdAdminExecutorCreator.java
b/proxy/backend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/backend/firebird/handler/admin/FirebirdAdminExecutorCreator.java
index 3420eb9840f..534e9b6f37e 100644
---
a/proxy/backend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/backend/firebird/handler/admin/FirebirdAdminExecutorCreator.java
+++
b/proxy/backend/dialect/firebird/src/main/java/org/apache/shardingsphere/proxy/backend/firebird/handler/admin/FirebirdAdminExecutorCreator.java
@@ -25,7 +25,6 @@ import
org.apache.shardingsphere.proxy.backend.handler.admin.executor.DatabaseAd
import
org.apache.shardingsphere.sql.parser.statement.core.statement.SQLStatement;
import
org.apache.shardingsphere.sql.parser.statement.core.statement.type.dal.SetStatement;
import
org.apache.shardingsphere.sql.parser.statement.core.statement.type.dal.ShowStatement;
-import
org.apache.shardingsphere.sql.parser.statement.core.statement.type.dml.SelectStatement;
import java.util.List;
import java.util.Optional;
@@ -38,10 +37,6 @@ public final class FirebirdAdminExecutorCreator implements
DatabaseAdminExecutor
@Override
public Optional<DatabaseAdminExecutor> create(final SQLStatementContext
sqlStatementContext, final String sql, final String databaseName, final
List<Object> parameters) {
SQLStatement sqlStatement = sqlStatementContext.getSqlStatement();
- // TODO add support for Firebird system tables
- if (sqlStatement instanceof SelectStatement) {
- return Optional.empty();
- }
if (sqlStatement instanceof SetStatement) {
return Optional.of(new
FirebirdSetVariableAdminExecutor((SetStatement) sqlStatement));
}
diff --git a/test/e2e/sql/src/test/resources/cases/dml/e2e-dml-insert.xml
b/test/e2e/sql/src/test/resources/cases/dml/e2e-dml-insert.xml
index cedb39c730c..f9c903ce673 100644
--- a/test/e2e/sql/src/test/resources/cases/dml/e2e-dml-insert.xml
+++ b/test/e2e/sql/src/test/resources/cases/dml/e2e-dml-insert.xml
@@ -187,7 +187,6 @@
</test-case>
<test-case sql="INSERT INTO t_data_type_integer_unsigned (id,
col_bigint_unsigned, col_int_unsigned, col_mediumint_unsigned,
col_smallint_unsigned, col_tinyint_unsigned) values (?, ?, ?, ?, ?, ?)"
db-types="MySQL" scenario-types="passthrough">
- <!-- TODO Test unsigned with MySQL Connector/J 8.0.x client
https://github.com/apache/shardingsphere/issues/14349 -->
<assertion parameters="1:int, 18446744073709551615:decimal,
4294967295:long, 16777215:int, 65535:int, 255:smallint"
expected-data-file="insert_max_values_into_single_table_integer_unsigned.xml" />
<assertion parameters="2:int, 0:long, 0:int, 0:int, 0:smallint,
0:tinyint"
expected-data-file="insert_min_values_into_single_table_integer_unsigned.xml" />
</test-case>
