Gimini-3 opened a new pull request, #39233:
URL: https://github.com/apache/shardingsphere/pull/39233
Fixes #39221.
Changes proposed in this pull request:
- Return zero-length MySQL binary TIME values before reading sign and days
fields.
- Preserve the existing length-8 and length-12 decoding paths.
- Add a real `MySQLPacketPayload` regression test that proves the
following int4 value 1234 remains unread.
- Update the Release Notes.
Verification:
- Reproduced the pre-fix failure with the real 5-byte payload `00 D2 04 00
00`: `IndexOutOfBoundsException` while reading days.
- Passed `MySQLTimeBinaryProtocolValueTest` with 100% class, line, and
branch coverage for the target class.
- Passed all tests in `database/protocol/dialect/mysql`.
- Passed Spotless, Checkstyle, and `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e` locally with JDK 25.
Requested assignment and the remaining `in: proxy` and `in: protocol` labels
in #39221; `type: bug` and `db: MySQL` are already applied.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [x] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
