somiljain2006 commented on PR #39225: URL: https://github.com/apache/shardingsphere/pull/39225#issuecomment-5135007752
@terrymanu Thanks for the review. They make the architectural concerns much clearer. My understanding is that there are two ownership decisions we should resolve before continuing. **1. Shared metadata contract** One possible direction is to make `typeName` part of the shared metadata model. If that's the intended design, I'd complete the contract by persisting it through `YamlShardingSphereColumn` and `YamlColumnSwapper` so metadata survives the existing persistence and reload path. Alternatively, if PostgreSQL type identity is intended to remain protocol-local, I'd remove `typeName` from the shared metadata model instead of leaving it half-integrated. **2. Authoritative type resolution** I agree that the resolver is too late in the extended protocol flow to become the authoritative owner. My current thought is that type resolution should occur before parameter decoding, while reusing existing statement semantics (for example, Binder/Describe metadata) rather than introducing another statement-to-column mapping within the resolver. That would also allow the fast path to remain unchanged so ordinary text binds avoid additional metadata lookups. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
