somiljain2006 commented on PR #39225: URL: https://github.com/apache/shardingsphere/pull/39225#issuecomment-5259306267
@terrymanu Thanks for the detailed review. I’ve reworked the implementation around the requested architectural boundaries. * PostgreSQL parameter type state is now retained by `PostgreSQLServerPreparedStatement` for Describe, Bind, repeated execution, and batch execution. * Bind-first flows preserve `UNSPECIFIED` parameters until their types are resolved, without prematurely decoding them as JSON or treating arbitrary `Types.OTHER` values as JSON. * Parameter resolution reuses the existing Binder/Describe semantics rather than maintaining a separate partial parameter-to-column traversal. * `typeName` is handled as shared column metadata with the corresponding YAML swapper, persistence/reload support, and round-trip coverage. * The existing fast path for already-resolved text parameters remains unchanged. * Implicit INSERT columns, multi-row `VALUES`, UPDATE expressions, and multi-table statements are covered through the existing semantic resolution path. * Added/updated coverage for Describe-first, Bind-first, repeated Bind, batch execution, custom types, ordinary `VARCHAR`, metadata persistence round trips, and the reused openGauss paths. * All tests are passing locally, and I also fixed the OpenGauss test mock exposed by CI. I believe the requested changes are now fully addressed. Please take another look when you have a chance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
