thswlsqls opened a new pull request, #39363:
URL: https://github.com/apache/shardingsphere/pull/39363
Fixes #39360.
Changes proposed in this pull request:
- Remove the `ADDRESS_RANDOM_REPLACE` lexer token from
`features/mask/distsql/parser/src/main/antlr4/imports/mask/Keyword.g4`; no
parser rule references it and no matching `MaskAlgorithm` exists in the
repository.
- The token preceded `IDENTIFIER_`, so `address_random_replace` was
rejected as a mask rule name, column name or database name. Removing it lets
those words fall back to `IDENTIFIER_`, the same intended result as #39012.
- Add `MaskDistSQLStatementVisitorTest`, mirroring
`ShardingDistSQLStatementVisitorTest`; three cases cover the previously
rejected statements and one guards the existing `GENERIC_TABLE_RANDOM_REPLACE`
built-in type against regression.
- This completes the built-in mask algorithm cleanup requested in #24847:
#24848 removed only the `BaseRule.g4` alternative, and #28071 removed both
files for the five sibling algorithms.
- No documentation update is required: `reserved-word.en.md` and
`reserved-word.cn.md` list only `MASK` and `COLUMNS` under MASK, so this token
was never a documented reserved word — unlike #39012, whose tokens were
documented and updated together.
- Other unused tokens remain in the feature DistSQL grammars. They have no
comparable removal history and are left for separate assessment.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
