thswlsqls commented on PR #39363: URL: https://github.com/apache/shardingsphere/pull/39363#issuecomment-5549818624
@terrymanu Thanks for the review. I'll remove `MaskDistSQLStatementVisitorTest` and add one `address_random_replace` case to the existing Mask parser IT fixtures instead. One small note: `MigrationDistSQLStatementVisitorTest` is still on master and was updated after both migrations, so Mask would not be the only module-local one — but I'm happy to follow the convention here either way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
