terrymanu commented on issue #31494:
URL:
https://github.com/apache/shardingsphere/issues/31494#issuecomment-5386620473
Hi @iamhucong, all valid SQL cases in this issue are now supported on
master, so this issue can be closed as completed.
Most of the unchecked items are invalid fragments produced by the web
crawler (for example `) [types: [DATE]`), which are not executable SQL
statements. The five real CREATE TABLE cases are all covered on master:
- `PARTITION BY RANGE (k1) ()` with an empty partition list and `DISTRIBUTED
BY HASH ... PROPERTIES(...)` — supported by making the partition definition
list optional inside the parentheses in
`parser/sql/engine/dialect/doris/src/main/antlr4/imports/doris/DDLStatement.g4`
(#39566);
- `AGGREGATE KEY ... ROLLUP (...)` — supported by the new `rollupClause` in
the Doris `createTable` rule (#39566);
- `PROPERTIES("replication_allocation" = ...)` and
`PROPERTIES("storage_policy" = ...)` — supported by the Doris CREATE TABLE
enhancements in #39566 and #39568.
All five SQL statements from this issue were also added as Doris sql-cases
with assertions in
`test/it/parser/src/main/resources/sql/supported/ddl/create-table.xml` and
`test/it/parser/src/main/resources/case/ddl/create-table.xml`, and each one
parses and visits successfully on current master. Thanks for reporting and for
everyone's contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
