terrymanu commented on issue #31487:
URL:
https://github.com/apache/shardingsphere/issues/31487#issuecomment-5386625403
Hi @iamhucong, all SQL cases listed in this issue are already supported on
the current master, so I think we can close it as completed.
- The `ALTER TABLE ... RENAME` family (`RENAME new_table_name`, `RENAME
ROLLUP a b`, `RENAME PARTITION a b`, `RENAME COLUMN a b`, and `ALTER TABLE
table1 RENAME table2`) was implemented in #37537, including the grammar rules,
visitor segments, and assertion cases (`alter_table_rename_table_doris`,
`alter_table_rename_column_doris`, `alter_table_rename_rollup`,
`alter_table_rename_partition` in `sql/supported/ddl/alter-table.xml`).
- `UCASE` is covered by the existing case `select_ucase` (`SELECT
UCASE('hello')`, db-types `MySQL,Doris`), which @Rahulyadav4 also verified
locally.
- `ORTHOGONAL_BITMAP_EXPR_CALCULATE_COUNT` parses through the generic
function-call rule, since the Doris grammar accepts any qualified identifier as
a function name; sibling bitmap-function cases such as `BITMAP_OR_COUNT`
already exist, and I verified the exact SQL from the docs parses successfully
on master.
I re-checked every remaining unchecked case on master and all of them parse
without code changes, so there is nothing left to implement here. Thanks
@Rahulyadav4 for the verification. I'll close this issue as completed; feel
free to reopen if any listed SQL still fails on the latest master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
