zhang-arvin commented on PR #39540: URL: https://github.com/apache/shardingsphere/pull/39540#issuecomment-5541616899
Thanks for the review @terrymanu! Here's what was fixed: 1. **Blocking Issue 1 (batch accumulation + identifier policy)**: Changed `put()` to `computeIfAbsent()` + `addAll()` so multi-batch materials for the same storage unit accumulate. Replaced `toLowerCase()` with `IdentifierCasePolicy.normalizeForLookup()` per storage unit. 2. **Blocking Issue 2 (behavioral tests)**: Added 4 new log-capture tests verifying missing-table warnings, multi-batch accumulation, and SQLException handling. All 11 tests pass (7 existing + 4 new). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
