zhang-arvin commented on PR #39540: URL: https://github.com/apache/shardingsphere/pull/39540#issuecomment-5573691906
@terrymanu Thanks for the review! I've fixed the style issues that were failing CI: 1. **Check-Style**: Replaced `Map.Entry` with `Entry` (imported `java.util.Map.Entry`) in `MetaDataLoader.java` per the checkstyle rule. 2. **Spotless**: Removed the fully-qualified `ch.qos.logback.classic.Logger` usage in `MetaDataLoaderTest.java` and added the proper import, per the format violations reported by spotless. Verified locally: `./mvnw checkstyle:check -pl database/connector/core -Pcheck` and `./mvnw spotless:check -pl database/connector/core -Pcheck` both pass now. The two blocking issues from your review remain addressed as described in my previous comment (per-storage-unit batch accumulation with `computeIfAbsent` + `addAll`, `IdentifierCasePolicy.normalizeForLookup` instead of `toLowerCase`, and 4 new log-capture behavioral tests). Please re-review when you have a chance. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
