ClaireLytt commented on PR #39786: URL: https://github.com/apache/shardingsphere/pull/39786#issuecomment-5773755897
@terrymanu Hi, thanks for the review! I've pushed fixes for both blocking issues from round 4. **Issue 1: Case-sensitive remote tables can resolve to the wrong logical table** `LinkedServerTable` now uses a standard `LinkedHashMap` (case-sensitive) instead of `CaseInsensitiveMap`. This preserves distinct remote identities — a lookup for `humanresources.dbo.department` returns empty when only `HumanResources.dbo.Department` is configured. New test: `assertFindLogicalTableWithCaseDifferentTableIdentityReturnsEmpty` — verifies that an unconfigured case-different table identity fails closed. The existing `assertFindLogicalTableWithCaseInsensitiveServerName` test confirms that server-name lookup remains case-insensitive (correct for SQL Server linked server names), while table-identity lookup is case-sensitive. **Issue 2: Style violations** - All three wrapped `checkArgument` calls (170, 182, 191 chars) in `LinkedServerRule.java` and `LinkedServerConfiguration.java` have been unwrapped to single lines. The remaining wrapped call (276 chars) correctly exceeds the 200-character threshold. - Renamed `result` variables to `actual` prefix (`actualServerName`, `actualSegment`, `actualYamlConfig`, `actualConfig`) in `OpenQueryUtilsTest` and `YamlLinkedServerRuleConfigurationSwapperTest`. - Unwrapped `getLogicTableNames()` in `LinkedServerRuleConfiguration` to a single line. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
