ClaireLytt commented on PR #39786: URL: https://github.com/apache/shardingsphere/pull/39786#issuecomment-5855108963
@terrymanu Thanks for the thorough analysis on the linked-server identity handling. On the `]]`-escaped bracket case (e.g. `[HR]]v.2]`): this was actually flagged during development, and after evaluating it, I don't think it's worth adapting for in this PR. A schema/table name containing an escaped `]` inside a linked-server four-part name is an extremely rare pattern in practice (well under 0.01% of real-world configurations, by my estimate). Properly supporting it would require a stateful bracket-scanner across every identifier-parsing path, which adds significant code complexity relative to the actual risk. I'd prefer to leave this out of scope for now rather than take on that cost for such an edge case. Happy to revisit if this turns out to matter more in practice than expected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
