rishi-rana commented on PR #39882:
URL: https://github.com/apache/shardingsphere/pull/39882#issuecomment-5999758143
Thanks, both correctness findings confirmed and addressed in b65352b219f,
along with the style findings.
1. `ProxySQLExecutor.java:156` /
`StandardDatabaseProxyConnector.java:295-301` — the deferral condition now
checks transaction type via `isInDeferrableTransaction()` and excludes BASE. A
BASE transaction's DDL now refreshes synchronously instead of being queued and
discarded on rollback.
2. `ContextManager.java:302` — when `reconcileTable` determines the table
does not exist, it now removes the speculative single-table route registration
the loader adds before dropping, instead of leaving it behind.
3. `DeferredMetaDataRefreshContextTest.java:33` — class declared `final`.
`PostgreSQLDDLMetaDataRefreshTestCase.java:83` — `awaitQueryable` moved
to immediately follow `assertCreatedTableReconciledAfterCommit`.
`ProxySQLExecutor.java:153`, `ContextManagerTest.java:392`,
`MySQLDDLMetaDataRefreshTestCase.java:73`,
`PostgreSQLDDLMetaDataRefreshTestCase.java:109,126` — unwrapped.
Verification: 921 tests pass across the full `mode/core` and
`proxy/backend/core` modules (not just the changed classes);
`test/e2e/operation/transaction` compiles; `spotless:check checkstyle:check
-Pcheck` clean on all twelve modules.
4. Still awaiting your sign-off on the support contract from the earlier
comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
