rishi-rana commented on PR #39882:
URL: https://github.com/apache/shardingsphere/pull/39882#issuecomment-6005196519
Correction to my last comment's point 3:
`DeferredMetaDataRefreshContestTest.java:33 — class declared final.`
CI failed after that push. `checkstyle:check` runs against the PR's merge
ref, and a rule landed on `master` since this branch's base that explicitly
forbids `final` on a class named `*Test`:
```xml
<module name="MatchXpath">
<property name="query" value="//CLASS_DEF[./IDENT[ends-with(@text,
'Test')]]/MODIFIERS/FINAL" />
<message key="matchxpath.match" value="Unit-test classes must not be
declared final." />
</module>
```
That directly contradicts the finding I implemented. Reverted in
8ba4e568e0a; verified against a worktree merging this branch onto current
`master` before pushing. CheckStyle on the merge ref now passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
