The GitHub Actions job "Required - Check" on shardingsphere.git/fix-39935-firebird-common-responses has failed. Run started by GitHub user abhinav-phi (triggered by linghengqian).
Head commit for run: 0415dd9983f275f3923d04c5c47fcd92f6e56d14 / Abhinav <[email protected]> Preserve logical slice lengths and encode slice elements per XDR The slice response took pre-encoded bytes and derived the slice data length from the encoded buffer size. The server instead writes the same total logical byte length to both p_slr_length and p_slr_slice.lstr_length, and encodes the elements individually on non-symmetric connections, where a SMALLINT occupies four XDR bytes although its logical size is two bytes. Supplying encoded elements therefore wrote a data length of 4 instead of 2, and a decoder read the following packet as another array element. FirebirdSliceResponsePacket now takes the total logical byte length, the element column type and the element values, writes the logical length twice, and encodes each element through FirebirdBinaryProtocolValueFactory, the same pattern as FirebirdFetchResponsePacket.writeRowData. Also addresses the remaining review findings: - All five new tests invoke the public FirebirdPacket.write (PacketPayload) overload instead of the protected write(FirebirdPacketPayload). - The five new test classes are declared final. A SMALLINT slice regression asserts literal hand-derived bytes for one element with logical length 2 and encoded data of 4 bytes, and appends an op_dummy packet to verify the next packet starts at its own boundary. Generated-by: MiniMax Code (MCode) Report URL: https://github.com/apache/shardingsphere/actions/runs/37336435560 With regards, GitHub Actions via GitBox
