The GitHub Actions job "Required - Check" on 
shardingsphere.git/fix-39935-firebird-common-responses has failed.
Run started by GitHub user abhinav-phi (triggered by linghengqian).

Head commit for run:
a7c75d5f5cee88323f44ae4bc99256e41e6fe6cb / Abhinav <[email protected]>
Encode text slice elements as fixed length opaque data

Firebird writes a text array element with xdr_opaque of its storage length
(src/common/xdr.cpp, dtype_text), so no length field precedes it, while
FirebirdStringBinaryProtocolValue writes the length prefixed shape that a
row value needs. Routing a TEXT slice through that encoder emitted 20 bytes
for a CHAR(1) slice instead of 16 and let the client read the following
element bytes as the next packet opcode.

FirebirdSliceResponsePacket now takes the logical length of one element and
writes TEXT and LEGACY_TEXT through a new FirebirdPacketPayload.writeOpaque,
which zero fills to that length and pads to a 4-byte boundary without a
leading length. Other column types keep the binary protocol values.

Also follows the repository rules the automated checks do not enforce: the
elements parameter is Collection where only iteration is required, enhanced
loop variables are named each, each top level element of the Stream.of list
is on its own continuation line, and assertWriteBytes now immediately
follows its first caller.

Report URL: https://github.com/apache/shardingsphere/actions/runs/38096930858

With regards,
GitHub Actions via GitBox

Reply via email to