strongduanmu opened a new pull request, #40120:
URL: https://github.com/apache/shardingsphere/pull/40120
Changes proposed in this pull request:
- Preserve the configured GitHub branch when loading external cases,
restrict MySQL inputs to `.test` files, and exclude mysqltest connection
commands, control directives, and file/script payloads. Respect routine
delimiters, source character sets, and MySQL 8.0 executable-comment versions.
- Support valid MySQL syntax observed in the external corpus: additional
CREATE TABLE definitions and type aliases, CREATE FUNCTION/CREATE TRIGGER IF
NOT EXISTS, INSTALL COMPONENT SET, LOAD XML ROWS IDENTIFIED BY, qualified
identifiers and wildcards, account hosts, and SELECT function variants.
- Correct charset/collation visitor construction, CONVERT USING
parameters, and SQL_TSI interval mapping. Reuse the existing generic
SQLStatement for GET DIAGNOSTICS.
- Keep copied Doris grammar changes aligned and add paired parser SQL/AST
cases with source-position and semantic assertions.
The failing MySQL cases were identified from the [nightly SQL parser
run](https://github.com/apache/shardingsphere/actions/runs/37822398925).
mysqltest commands and payloads are filtered at input loading; valid SQL
remains subject to parser and visitor validation.
### Validation
- Full CI build: `./mvnw clean install -T1C -B -ntp -fae`.
- All internal parser tests, including 1,939 MySQL and 1,411 Doris cases.
- Complete `ExternalMySQLParserIT` against the configured MySQL 8.0 corpus:
64,910 cases, zero failures, errors, or skips.
- Spotless and Checkstyle for every changed Java file; full Apache RAT check.
- Remote Ubuntu benchmarks compare the original baseline with the final
lexer/parser and visitor implementations using identical workloads, warmup,
latency, and allocation measurements.
### Release Note
Category: **Enhancement**
Support additional MySQL CREATE TABLE, CREATE FUNCTION, CREATE TRIGGER,
INSTALL COMPONENT, LOAD XML, GET DIAGNOSTICS and SELECT syntax.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [x] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed maven check locally: `./mvnw clean install -T1C -B -ntp
-fae`.
- [x] I have made corresponding changes to the documentation.
- [x] I have added corresponding parser integration tests for my changes.
- [x] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
- [ ] I have disclosed the tool and affected files or scope for any material
AI assistance, as required by the [AI-assisted contribution policy].
[AI-assisted contribution policy]:
https://github.com/apache/shardingsphere/blob/master/AI_POLICY.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
