strongduanmu commented on PR #40120:
URL: https://github.com/apache/shardingsphere/pull/40120#issuecomment-6096424803
• ### Result
**Review Result: Mergeable**
Both issues have been fixed. The latest upstream master has been merged,
conflicts have been resolved, and all requested local checks have passed.
### Evidence
- The MySQL case loader preserves executable comments and SQL following
ordinary block comments. It decodes latin1 using MySQL’s Windows-1252 mapping
while preserving the five
special control bytes. No unit tests were added for the test
infrastructure.
- The existing local cache was reused directly: 802 `.test` / `.result`
pairs, totaling 1,604 files, all verified against official Git blob hashes. The
existing loading, expected-
result filtering, parsing, and visitor flows ran in full, with input
downloads supplied by a temporary cache provider.
| Verification | Result |
| --- | --- |
| MySQL external parser IT | 64,914 cases; 0 failures, 0 errors, 0 skips |
| All internal parser ITs | 21 test classes, 10,798 cases; 0 failures, 0
errors; 1 previously disabled case |
| Local CI | All 443 Maven projects succeeded; 28,668 tests, 0 failures, 0
errors, 149 existing skips |
| Spotless, Checkstyle, Apache RAT | Repository-wide checks passed; exit
code 0 |
All 64,910 previously passing external cases were retained. Four
previously omitted executable-comment cases were added, and five SQL text
changes correspond to the corrected
latin1 decoding.
Internal IT command:
`./mvnw -pl test/it/parser -DskipITs -Dspotless.skip=true
-Dtest=Internal*ParserIT test -B -ntp`
Local CI ran in an isolated snapshot whose 17,754 tracked files were
byte-for-byte identical to the workspace:
`./mvnw clean install -T2 -B -ntp -fae
-Dmaven.repo.local=<isolated-repository>`
Style and license command:
`./mvnw spotless:check checkstyle:check apache-rat:check -Pcheck -T2 -B
-ntp`
### Coverage
This report covers the local PR candidate reviewed before commit and push:
public head `6e3c02183681`, original merge-base `51a09f146116`, local merge
commit `e0d283027490`
incorporating upstream master `70a17f43be57`, plus the then-uncommitted
MySQL loader fix. The remote PR had not yet been updated at that point.
The review covered the public PR’s 61 files and the authorized upstream
merge changes, totaling 99 files. It examined grammar and AST behavior, shared
consumers, external loading,
internal assertions, and upstream merge content. Root-cause, blast-radius,
runtime verification, and final convergence reviews were completed. The
independent defensive-code review
passed, with no remaining blockers. Deletions were treated as expected, as
confirmed by the user. The changes preserve the existing MySQL parsing contract
without introducing a new
project commitment. CI coverage was local verification on JDK 21; remote
Actions status was not rechecked.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
