thswlsqls opened a new pull request, #40200:
URL: https://github.com/apache/shardingsphere/pull/40200
Fixes #40198.
Changes proposed in this pull request:
- `ConvertYamlConfigurationExecutor.getDataSourcePoolProps()` skipped null
values but chose separators by `iterator.hasNext()`, and always added a comma
before custom pool properties. A data source without `maxPoolSize` produced
`PROPERTIES(...'30000',)`, and one with only custom pool properties produced
`PROPERTIES(,'foo1'='bar_1')`; the DistSQL grammar rejects both.
- Merge standard and custom properties into one `LinkedHashMap`, drop null
values, and join with `Collectors.joining(",")`; the now-unused single-argument
overload is removed. Output for existing cases is unchanged.
- Add `without-max-pool-size` and `custom-pool-props-only` cases to
`ConvertYamlConfigurationExecutorTest`; both fail on master and pass with this
change.
AI assistance: Claude Code was used to draft the change and its unit tests
in `infra/distsql-handler` and `proxy/backend/core`. I reviewed, verified, and
take responsibility for every line submitted.
---
Before committing this PR, I'm sure that I have checked the following
options:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request. Requesting labels: `type: bug`, `feature: DistSQL`.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C
-Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`. Full build not run; ran repo-wide
`spotless:check checkstyle:check apache-rat:check -Pcheck`, `./mvnw install -pl
infra/distsql-handler,proxy/backend/core -am`, and the `infra/distsql-handler`
(90 passed) and `proxy/backend/core` (598 passed) tests.
- [ ] I have made corresponding changes to the documentation. No
documentation change is needed.
- [x] I have added corresponding unit tests for my changes.
- [x] I have updated the Release Notes of the current development version.
For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/)
- [x] I have disclosed the tool and affected files or scope for any material
AI assistance, as required by the [AI-assisted contribution policy].
[AI-assisted contribution policy]:
https://github.com/apache/shardingsphere/blob/master/AI_POLICY.md
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
