thswlsqls commented on PR #40200:
URL: https://github.com/apache/shardingsphere/pull/40200#issuecomment-6250083476
@terrymanu Thanks for the review. Both fixed:
`createYamlConfigWithCustomPoolPropsOnly` now builds the props with
`PropertiesBuilder.build(new Property("foo_1", "bar_1"))`, and
`createConnectionOnlyDataSourceConfig` and `createYamlConfig` now directly
follow their first caller in call order. `ConvertYamlConfigurationExecutorTest`
passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
