schizophrenicmaniac opened a new pull request, #40294:
URL: https://github.com/apache/shardingsphere/pull/40294
Fixes #40279.
Changes proposed in this pull request:
- In `FirebirdPrepareStatementCommandExecutor#processReturnValues`, map
`OLD.` and `NEW.` columns in `RETURNING` to the target table instead of looking
up tables named OLD and NEW.
- Describe a CTE column that has no physical table (for example `N` in
`WITH RECURSIVE R (N) AS (SELECT 1 ... UNION ALL ...)`) from the matching
projection of the CTE's anchor select. The column is matched by the CTE column
list, or by the anchor select's labels when there is no list, and keeps its own
label as the alias.
- Add unit tests for a recursive CTE, a CTE without a column list, and
`UPDATE ... RETURNING OLD.id, NEW.id`.
---
Before submitting this PR, I confirm that:
- [x] My code follows the [code of
conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/)
of this project.
- [x] I have reviewed my changes.
- [ ] I have (or in comment I request) added corresponding labels for the
pull request.
- [x] I have passed the required local checks: `./mvnw clean install -B -T1C
-Pcheck` (run for the affected module `proxy/frontend/dialect/firebird`).
- [ ] I have updated the relevant documentation, if applicable.
- [x] I have added or updated unit tests for my changes, if applicable.
- [ ] I have updated the Release Notes of the current development version,
if applicable. For more details, see [Update Release
Note](https://shardingsphere.apache.org/community/en/involved/contribute/contributor/).
AI disclosure: drafted with Claude Code (Claude Opus 5.5); files:
FirebirdPrepareStatementCommandExecutor.java,
FirebirdPrepareStatementCommandExecutorTest.java.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
