schizophrenicmaniac commented on PR #40294: URL: https://github.com/apache/shardingsphere/pull/40294#issuecomment-6341636655
@terrymanu Thanks, all four are fixed in the latest commit. For the collision, the lookup now checks whether the column is one of the actual columns of a `*` in that SELECT. Those columns carry the CTE name as owner, so for them the owner is matched against the CTE name of each FROM source rather than its alias. Explicit columns are still matched against the alias or name, and the old fallback loop is gone. I added tests for both `foo_alias.*` and `foo_cte.n` with `FROM foo_cte foo_alias JOIN bar_cte foo_cte`. The two comments are removed, `isTemporaryColumnWithoutTable` now comes before `getProjectionSelect`, and `getProjections` uses the derived table's subquery context directly without the null fallback. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
